refactor!: insert metadata directly and remove genesis transactions by KaoImin · Pull Request #1454 · axonweb3/axon

KaoImin · 2023-09-27T07:28:38Z

What this PR does / why we need it?

This PR removes the generation of genesis transactions. The first two metadata and the consensus config are inserted to DB directly.

What is the impact of this PR?

No Breaking Change

PR relation:

Ref #

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

CI Description

CI Name	Description
Web3 Compatible Test	Test the Web3 compatibility of Axon
v3 Core Test	Run the compatibility tests provided by Uniswap V3
OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19	Run the compatibility tests provided by OpenZeppelin

core/run/src/tests.rs

core/run/src/components/chain_spec.rs

Flouse

Now the following code is useless, right?

axon/core/run/src/tests.rs

Lines 130 to 147 in f000c0f

    
           for (i, (block_cached, tx)) in genesis 
        
               .block 
        
               .tx_hashes 
        
               .iter() 
        
               .zip(genesis.txs.iter()) 
        
               .enumerate() 
        
           { 
        
               let tx_cached = tx.transaction.hash; 
        
               assert_eq!( 
        
                   *block_cached, tx_cached, 
        
                   "check hash of tx[{i}], in-block: {block_cached:#x}, tx-cached: {tx_cached:#x}", 
        
               ); 
        
               let calculated = tx.transaction.clone().calc_hash().hash; 
        
               assert_eq!( 
        
                   tx_cached, calculated, 
        
                   "check hash of tx[{i}], cached: {tx_cached:#x}, calculated: {calculated:#x}", 
        
               ); 
        
           }

core/run/src/lib.rs

core/run/src/tests.rs

KaoImin · 2023-10-07T07:35:05Z

Now the following code is useless, right?

axon/core/run/src/tests.rs

Lines 130 to 147 in f000c0f

for (i, (block_cached, tx)) in genesis

.block

.tx_hashes

.iter()

.zip(genesis.txs.iter())

.enumerate()

{

let tx_cached = tx.transaction.hash;

assert_eq!(

*block_cached, tx_cached,

"check hash of tx[{i}], in-block: {block_cached:#x}, tx-cached: {tx_cached:#x}",

);

let calculated = tx.transaction.clone().calc_hash().hash;

assert_eq!(

tx_cached, calculated,

"check hash of tx[{i}], cached: {tx_cached:#x}, calculated: {calculated:#x}",

);

}

Yes

Flouse · 2023-10-09T06:34:22Z

/run-ci

github-actions · 2023-10-09T06:34:35Z

CI tests run on commit:

commit id: 7d73ca2

CI test list:

OCT 1-5 And 12-15
OCT 6-10
OCT 11
OCT 16-19
v3 Core Tests
Web3 Compatible Tests

Please check ci test results later.

core/executor/src/system_contract/mod.rs

core/run/src/tests.rs

KaoImin requested a review from a team as a code owner September 27, 2023 07:28

KaoImin requested review from ashuralyk and driftluo September 27, 2023 07:28

github-actions bot added the refactor label Sep 27, 2023

KaoImin requested review from Flouse and chaoticlonghair and removed request for ashuralyk September 27, 2023 07:28

KaoImin mentioned this pull request Sep 27, 2023

feat: first hardfork with contract size limit #1451

Merged

6 tasks

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

chaoticlonghair mentioned this pull request Sep 29, 2023

Call the built-in Metadata contract causes an error. #1457

Closed

4 tasks

chaoticlonghair reviewed Sep 29, 2023

View reviewed changes

core/run/src/tests.rs Show resolved Hide resolved

core/run/src/components/chain_spec.rs Show resolved Hide resolved

Flouse assigned KaoImin Oct 1, 2023

Flouse reviewed Oct 1, 2023

View reviewed changes

core/run/src/lib.rs Outdated Show resolved Hide resolved

Flouse reviewed Oct 1, 2023

View reviewed changes

core/run/src/tests.rs Outdated Show resolved Hide resolved

KaoImin force-pushed the remove-genesis-transaction branch from f000c0f to 1df6ee1 Compare October 7, 2023 01:56

KaoImin force-pushed the remove-genesis-transaction branch from 94f68f6 to dacb972 Compare October 8, 2023 13:14

KaoImin requested review from Flouse and chaoticlonghair October 8, 2023 13:14

This comment was marked as outdated.

Sign in to view

KaoImin added 4 commits October 9, 2023 12:12

refactor: insert metadata directly when init chain

eca8561

add unit test case

3a55e3e

follow review opinion

2105d8e

test: extend unit test scope

7d73ca2

KaoImin force-pushed the remove-genesis-transaction branch from dacb972 to 7d73ca2 Compare October 9, 2023 04:14

Flouse reviewed Oct 9, 2023

View reviewed changes

core/executor/src/system_contract/mod.rs Show resolved Hide resolved

driftluo approved these changes Oct 9, 2023

View reviewed changes

chaoticlonghair reviewed Oct 9, 2023

View reviewed changes

core/run/src/tests.rs Show resolved Hide resolved

chaoticlonghair approved these changes Oct 9, 2023

View reviewed changes

KaoImin enabled auto-merge October 9, 2023 07:35

KaoImin added this pull request to the merge queue Oct 9, 2023

Flouse mentioned this pull request Oct 9, 2023

Tracking issue for code style, comments etc. #1464

Open

4 tasks

Merged via the queue into main with commit 5b2310c Oct 9, 2023

This was referenced Oct 10, 2023

fix(test): check genesis before it completed #1466

Merged

refactor(cli): initialize chain without any secret key #1467

Merged

fix: the default (or empty) values of genesis fields should be same as normal blocks #1468

Merged

KaoImin deleted the remove-genesis-transaction branch October 12, 2023 07:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: insert metadata directly and remove genesis transactions#1454

refactor!: insert metadata directly and remove genesis transactions#1454
KaoImin merged 4 commits intomainfrom
remove-genesis-transaction

KaoImin commented Sep 27, 2023 •

edited by Flouse

Loading

Uh oh!

This comment was marked as off-topic.

This comment was marked as outdated.

Uh oh!

Uh oh!

Flouse left a comment

Uh oh!

Uh oh!

Uh oh!

KaoImin commented Oct 7, 2023

Now the following code is useless, right?

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Flouse commented Oct 9, 2023

Uh oh!

github-actions bot commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	for (i, (block_cached, tx)) in genesis
	.block
	.tx_hashes
	.iter()
	.zip(genesis.txs.iter())
	.enumerate()
	{
	let tx_cached = tx.transaction.hash;
	assert_eq!(
	*block_cached, tx_cached,
	"check hash of tx[{i}], in-block: {block_cached:#x}, tx-cached: {tx_cached:#x}",
	);
	let calculated = tx.transaction.clone().calc_hash().hash;
	assert_eq!(
	tx_cached, calculated,
	"check hash of tx[{i}], cached: {tx_cached:#x}, calculated: {calculated:#x}",
	);
	}

Conversation

KaoImin commented Sep 27, 2023 • edited by Flouse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it?

What is the impact of this PR?

CI Usage

CI Description

Uh oh!

This comment was marked as off-topic.

This comment was marked as outdated.

Uh oh!

Uh oh!

Flouse left a comment

Choose a reason for hiding this comment

Now the following code is useless, right?

Uh oh!

Uh oh!

Uh oh!

KaoImin commented Oct 7, 2023

Now the following code is useless, right?

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Flouse commented Oct 9, 2023

Uh oh!

github-actions bot commented Oct 9, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KaoImin commented Sep 27, 2023 •

edited by Flouse

Loading