Skip to content

fix(API): display of signature v in transaction#1431

Merged
KaoImin merged 2 commits intomainfrom
fix-display-v
Sep 15, 2023
Merged

fix(API): display of signature v in transaction#1431
KaoImin merged 2 commits intomainfrom
fix-display-v

Conversation

@KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Sep 14, 2023 •
edited
Loading

What this PR does / why we need it?

This PR adds chain_id to v in the return of eth_getTransactionByHash. It uses standard_v which is 0 or 1 previously, and now the v adds chain_id protection with the formula v = standard_v + chain_id * 2 + 35.

What is the impact of this PR?

No Breaking Change

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin KaoImin marked this pull request as ready for review September 14, 2023 10:03
@KaoImin KaoImin requested a review from a team as a code owner September 14, 2023 10:03
@KaoImin KaoImin requested review from Simon-Tl, chaoticlonghair, jjyr and sunchengzhu and removed request for Simon-Tl September 14, 2023 10:03
@Flouse Flouse linked an issue Sep 14, 2023 that may be closed by this pull request
Tracking features for address encoding #1343
Closed
4 tasks
@KaoImin
Copy link
Contributor Author

KaoImin commented Sep 15, 2023

/run-ci

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

CI tests run on commit:

CI test list:

  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin enabled auto-merge September 15, 2023 04:00
@KaoImin KaoImin added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 230f4eb Sep 15, 2023
@KaoImin KaoImin deleted the fix-display-v branch September 15, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjyr jjyr Awaiting requested review from jjyr jjyr is a code owner automatically assigned from axonweb3/axon-dev

2 more reviewers

@chaoticlonghair chaoticlonghair chaoticlonghair approved these changes

@sunchengzhu sunchengzhu sunchengzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking features for address encoding

3 participants

@KaoImin @chaoticlonghair @sunchengzhu