feat(cli): integrate genesis-generator into axon init#1402
Merged
Conversation
350431b to
88a29b9
Compare
genesis-generator into axon initgenesis-generator into axon init
88a29b9 to
88b269b
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
88b269b to
daac1bf
Compare
KaoImin
reviewed
Sep 6, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
previously approved these changes
Sep 7, 2023
Flouse
reviewed
Sep 7, 2023
42e33c0 to
ea3eee7
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
approved these changes
Sep 7, 2023
KaoImin
approved these changes
Sep 11, 2023
7 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
genesis-generatorintoaxon. #1346.=> All configurations could be readable.
Currently,
genesis-generatorhas too many hardcode variables,axon/devtools/genesis-generator/src/main.rs
Line 26 in 8815f58
axon/devtools/genesis-generator/src/main.rs
Lines 67 to 69 in 8815f58
axon/devtools/genesis-generator/src/main.rs
Line 115 in 8815f58
and requires all private keys of all nodes.
axon/devtools/genesis-generator/src/main.rs
Lines 97 to 102 in 8815f58
axon/devtools/genesis-generator/src/main.rs
Lines 124 to 129 in 8815f58
What is the impact of this PR?
BREAKING CHANGE:
Command line interface
The sub-command
axon runrequires a new argument--key $KEY_HEX_STR_WITH_0X_PREFIXor--key-file $KEY_IN_BINARY_FILE, to provided the private key of genesis transactions.CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwc