refactor: change the inner type of Hex#1371
Merged
chaoticlonghair merged 3 commits intomainfrom Aug 29, 2023
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Contributor
chaoticlonghair
left a comment
There was a problem hiding this comment.
I prefer the current method of handling hex strings.
Also, I have to point that:
-
The serde deserialization is changed.
-
Previous is not strict with
0xprefix. -
Current is strict with
0xprefix; no-prefix or0Xprefix is not acceptable.
-
-
But the
from_stringanddecodeis still not strict with0xprefix.
There should be only one rule for hex conversion to reduce ambiguity.
p.s. I prefer to use the strict method, but I don't persist in.
chaoticlonghair
previously approved these changes
Aug 29, 2023
Contributor
Author
|
/run-ci |
blckngm
previously approved these changes
Aug 29, 2023
Contributor
blckngm
left a comment
There was a problem hiding this comment.
Nit: it's a bit more idiomatic to use parse instead of from_str directly.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Contributor
Author
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
chaoticlonghair
approved these changes
Aug 29, 2023
blckngm
approved these changes
Aug 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Change the inner type of
HextoByteswith the following advantages:bytes::Bytesis very cheap.What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwc