Skip to content

fix(executor): should check all system contracts' address#1142

Merged
KaoImin merged 1 commit intomainfrom
@peter/fix-check-system-contract
Apr 10, 2023
Merged

fix(executor): should check all system contracts' address#1142
KaoImin merged 1 commit intomainfrom
@peter/fix-check-system-contract

Conversation

@peterzhb
Copy link
Contributor

@peterzhb peterzhb commented Apr 7, 2023 •
edited
Loading

What this PR does / why we need it:

This PR fixes the check of whether a call is system contract. There are currently 4 system contracts to be checked.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@peterzhb peterzhb requested a review from a team as a code owner April 7, 2023 02:52
@github-actions github-actions bot added the bugfix label Apr 7, 2023
@peterzhb
Copy link
Contributor Author

peterzhb commented Apr 7, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 7, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Unit Tests

Please check ci test results later.

@peterzhb peterzhb force-pushed the @peter/fix-check-system-contract branch from 81b11a3 to e1d8c01 Compare April 7, 2023 12:30
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

The title of this PR does not conform the conventional commits. Please fix it, thx.

@peterzhb peterzhb changed the title fix[executor]: should check all system contracts' address fix(executor): should check all system contracts' address Apr 10, 2023
hongda3141
hongda3141 previously approved these changes Apr 10, 2023
View reviewed changes
@peterzhb peterzhb force-pushed the @peter/fix-check-system-contract branch from e1d8c01 to fe6f698 Compare April 10, 2023 01:25
@KaoImin KaoImin added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit c073aa9 Apr 10, 2023
@KaoImin KaoImin deleted the @peter/fix-check-system-contract branch April 10, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felicityin felicityin Awaiting requested review from felicityin

2 more reviewers

@KaoImin KaoImin KaoImin approved these changes

@hongda3141 hongda3141 hongda3141 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterzhb @KaoImin @hongda3141