Skip to content

refactor(executor): switch to metadata system contract#1115

Merged
KaoImin merged 4 commits intomainfrom
@peter/switch-to-metadata-system-contract
Apr 3, 2023
Merged

refactor(executor): switch to metadata system contract#1115
KaoImin merged 4 commits intomainfrom
@peter/switch-to-metadata-system-contract

Conversation

@peterzhb
Copy link
Contributor

@peterzhb peterzhb commented Mar 29, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it:

This PR switch the metadata contract from the solidity deployed one to the system contract.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@peterzhb peterzhb requested review from KaoImin and hongda3141 March 29, 2023 04:55
@peterzhb peterzhb requested a review from a team as a code owner March 29, 2023 04:55
@KaoImin KaoImin changed the title refactor[executor]: switch to metadata system contract refactor(executor): switch to metadata system contract Mar 29, 2023
@KaoImin
Copy link
Contributor

KaoImin commented Mar 30, 2023

@liya2017 Please check whether DevOps have to update or not.

@liya2017
Copy link
Contributor

liya2017 commented Mar 31, 2023

@liya2017 Please check whether DevOps have to update or not.

Yes, Devops should be update.
Does the genesis_multi_nodes.json need update too?

@KaoImin KaoImin marked this pull request as draft March 31, 2023 02:08
@peterzhb peterzhb force-pushed the @peter/switch-to-metadata-system-contract branch 5 times, most recently from ed3dd50 to ad95d03 Compare March 31, 2023 08:21
@peterzhb peterzhb marked this pull request as ready for review March 31, 2023 08:21
@peterzhb
Copy link
Contributor Author

peterzhb commented Mar 31, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 31, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Unit Tests

Please check ci test results later.

@peterzhb peterzhb force-pushed the @peter/switch-to-metadata-system-contract branch from ad95d03 to cdede5e Compare March 31, 2023 09:39
@KaoImin
Copy link
Contributor

KaoImin commented Mar 31, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 31, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@peterzhb
Copy link
Contributor Author

peterzhb commented Apr 3, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@peterzhb peterzhb force-pushed the @peter/switch-to-metadata-system-contract branch from 5ef6884 to 1a3fbd6 Compare April 3, 2023 06:20
@peterzhb
Copy link
Contributor Author

peterzhb commented Apr 3, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@peterzhb peterzhb force-pushed the @peter/switch-to-metadata-system-contract branch from 1a3fbd6 to 083b554 Compare April 3, 2023 08:16
@peterzhb
Copy link
Contributor Author

peterzhb commented Apr 3, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Apr 3, 2023
Merged via the queue into main with commit 55a713b Apr 3, 2023
@KaoImin KaoImin deleted the @peter/switch-to-metadata-system-contract branch April 3, 2023 11:49
@liya2017 liya2017 mentioned this pull request Apr 6, 2023
Closed
@wenyuanhust wenyuanhust mentioned this pull request Apr 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongda3141 hongda3141 Awaiting requested review from hongda3141

1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterzhb @KaoImin @liya2017