Use binary search to find fitting font size for labels shrinking on overflow. #2960
+92
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1670077 to
2536171
Compare
2536171 to
b6eb843
Compare
halx99
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2927.
I could not find flags for
FT_Load_Glyphthat would make it significantly faster, so I have just changed the way the font size is computed. Previouslyax::Label::alignTextwould decrease the font size until it found one that fit the text in the label's size. Now it will use a binary search to find this size.On my app, at launch, the original version spent an accumulated 1.73 s. in
ax::Label::alignText, with this patch it spends 0.82 s. Both averaged on 10 runs, release builds running on a Pixel 3a.I've checked this patch in all tests of the
Labelentry in cpp-tests.