Fix for xcarchive generation for iOS and MacOS when using OpenAL-Soft #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that dSym file is generated in correct directory
…_DIR on OpenAL-soft shared library
halx99
previously approved these changes
Nov 21, 2025
Collaborator
|
@rh101 prebuilt workflow check fail: |
Contributor
Author
I think it's fixed now, just took a while testing it out to make sure the MacOS build still worked without generating the linker error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This addresses the issue described in #2876
An extra change was required in
3rdparty/CMakeLists.txtto avoid a strange linker error when this attribute is set for the OpenAL-soft:XCODE_ATTRIBUTE_CONFIGURATION_BUILD_DIR "$(inherited)"It doesn't happen on iOS, but it shows a linker error on MacOS. The only way to fix it was to not force the setting of the output directories for shared libraries in
3rdparty/CMakeLists.txt. The linker error disappears and everything builds correctly with this change.Issue ticket number and link
#2876
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR