Fix reverb properties values #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
does possible remove preprocessor check: #if AX_USE_ALSOFT
/**
* Sets and enables reverb for an audio track.
*
* @param audioId An audioID returned by the play2d function.
* @param reverbProperties The pointer to reverb effect settings. If this is nullptr, then reverb effect will be
* disabled.
*/
static void setReverbProperties(AUDIO_ID audioId, const ReverbProperties* reverbProperties);
#endifor hidden for luabindings ? |
Collaborator
lua build will raise compile error when build for wasm without openal-soft |
Contributor
Author
|
There is an alternative solution. I'll push the changes soon. |
Contributor
Author
|
To avoid issues, we can always have |
Collaborator
ok |
halx99
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR