will your also add 3d API: int AudioEngine::play3d(const std::string& filePath, const Vec3& position, bool loop = false, float volume = 1.0f, const AudioProfile* profile = nullptr); ?

will your also add 3d API: int AudioEngine::play3d(const std::string& filePath, const Vec3& position, bool loop = false, float volume = 1.0f, const AudioProfile* profile = nullptr); ?

never mind, the audio panning still for 2d, right?

will your also add 3d API: int AudioEngine::play3d(const std::string& filePath, const Vec3& position, bool loop = false, float volume = 1.0f, const AudioProfile* profile = nullptr); ?

never mind, the audio panning still for 2d, right?

This implementation is only for 2D. Do you want me to try and add 3D panning to this PR?

will your also add 3d API: int AudioEngine::play3d(const std::string& filePath, const Vec3& position, bool loop = false, float volume = 1.0f, const AudioProfile* profile = nullptr); ?

will your also add 3d API: int AudioEngine::play3d(const std::string& filePath, const Vec3& position, bool loop = false, float volume = 1.0f, const AudioProfile* profile = nullptr); ?

never mind, the audio panning still for 2d, right?

This implementation is only for 2D. Do you want me to try and add 3D panning to this PR?

Maybe a separated PR is better due to current only have play2d API

Maybe a separated PR is better due to current only have play2d API

I can take a look at adding play3d sometime next week.

Using a value of -0.5 for the Z position, instead of -1.f, seems to give a better result for 2D audio panning, where it seems to completely silence the opposite side.

So this:
alSource3f(player->_alSource, AL_POSITION, player->_pan, 0.0f, -1.0f);
changes to:
alSource3f(player->_alSource, AL_POSITION, player->_pan, 0.0f, -0.5f);

Instead of hard-coding it, how about we introduce a new parameter to the setPan method, "distance", which is actually the Z value:
void AudioEngineImpl::setPan(AUDIO_ID audioId, float value, float distance = -0.5f)

so it would end up as;
alSource3f(player->_alSource, AL_POSITION, player->_pan, 0.0f, distance);

This way the developer can set it for the specific panning effect they want if the default is not suitable.

Also, we should add a method to get the current audio source position, such as:

ax::Vec3 AudioEngineImpl::getSourcePosition(int audioId)

This would cover both 2D and 3D audio.

@halx99 What is your opinion of this?

If ax::Vec3 AudioEngineImpl::getSourcePosition(int audioId) added, shoud we also add setSourcePosition ?

If ax::Vec3 AudioEngineImpl::getSourcePosition(int audioId) added, shoud we also add setSourcePosition ?

Yes, I'll add that too.

@halx99 I'm not quite sure why the iOS and OSX tests are failing, unless it's something I'm not seeing in the logs.

@halx99 I'm not quite sure why the iOS and OSX tests are failing, unless it's something I'm not seeing in the logs.

here: /Users/runner/work/axmol/axmol/core/audio/AudioPlayer.h:78:5: error: unknown type name 'Vec3'
78 | Vec3 _sourcePosition;

seems you miss include "math/Vec3.h" in AudioPlayer.h

here: /Users/runner/work/axmol/axmol/core/audio/AudioPlayer.h:78:5: error: unknown type name 'Vec3' 78 | Vec3 _sourcePosition;

seems you miss include "math/Vec3.h" in AudioPlayer.h

Thank you. I totally missed that in the logs.