FastTMXLayer: reset draw counts when layer becomes empty #2710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent removed tiles from rendering when a TMX layer becomes empty by zeroing existing `CustomCommand` index draw counts at the start of `updatePrimitives()` and then setting counts only for the current frame.
Collaborator
|
/clang-format |
Collaborator
|
👋 @halx99 Command /clang-format received. Running code formatting, please wait... |
Collaborator
|
✅ Formatting completed and changes have been committed to the PR branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent removed tiles from rendering when a TMX layer becomes empty by zeroing existing
CustomCommandindex draw counts at the start ofupdatePrimitives()and then setting counts only for the current frame.Describe your changes
FastTMXLayer::updatePrimitives(), add an early pass that callssetIndexDrawInfo(0, 0)on all existing entries in_customCommands.setIndexDrawInfo(start*6, count*6)only for the vertex-Z buckets used in the current frame.Issue ticket number and link
N/A