Skip to content

Conversation

@AlexandreK38
Copy link
Contributor

@AlexandreK38 AlexandreK38 commented Sep 1, 2025

Describe your changes

The Wasm downloader doesn't call any of the callbacks because there is an issue in emscripten with the id of the fetch given by emscripten_fetch() function, it always return 0 - except for one case not used in our downloader - You can learn more here: emscripten-core/emscripten#23124)

The solution is to use the fetch address instead of the id for the context map. As said in the issue thread, the address could be reused after the download is finished but in our case we remove the entry from the map once done too, so it's not problematic.

I also fixed the data of the task progress info as they weren't set at all

@halx99 halx99 added this to the 2.8.1 milestone Sep 1, 2025
@halx99 halx99 merged commit da3fc41 into axmolengine:release/2.x Sep 2, 2025
15 checks passed
@halx99
Copy link
Collaborator

halx99 commented Sep 2, 2025

lgtm, thanks

@AlexandreK38 AlexandreK38 deleted the fix-wasm-downloader branch September 2, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants