Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The Wasm downloader doesn't call any of the callbacks because there is an issue in emscripten with the id of the fetch given by
emscripten_fetch()function, it always return 0 - except for one case not used in our downloader - You can learn more here: emscripten-core/emscripten#23124)The solution is to use the fetch address instead of the id for the context map. As said in the issue thread, the address could be reused after the download is finished but in our case we remove the entry from the map once done too, so it's not problematic.
I also fixed the data of the task progress info as they weren't set at all