Skip to content

Conversation

@NgVThangBz
Copy link
Contributor

@NgVThangBz NgVThangBz commented Aug 7, 2025

fix Label render
Add test Label render:
Normal, SDF
Glow, Outline, Shadow, Bold
Change Size font, Scale, size outline

Screenshot 2025-08-07 at 10 11 58

@aismann
Copy link
Contributor

aismann commented Aug 7, 2025

Nice tester!
Can you look again: Size it not resizing SDF font (A new bug or a tester issue, I have not look at the source for now)
image

@NgVThangBz
Copy link
Contributor Author

@aismann im just add test, I think we should add test first, then fix bug
test in: https://github.com/NgVThangBz/axmol/tree/Fix-Label-Render
fix in: https://github.com/NgVThangBz/axmol/tree/fix-Label-SDF-render

@aismann
Copy link
Contributor

aismann commented Aug 7, 2025

@aismann im just add test, I think we should add test first, then fix bug test in: https://github.com/NgVThangBz/axmol/tree/Fix-Label-Render fix in: https://github.com/NgVThangBz/axmol/tree/fix-Label-SDF-render

Ok I see.
Plz add the fix also to this PR (title have to be changed?)
Fix and a needed test on the same PR is faster and the expected result (the tester shows the known bug) The goal is the fix in this PR.
Thanks.

@NgVThangBz NgVThangBz changed the title add test Label render fix Label render and add test case Aug 7, 2025
@halx99
Copy link
Collaborator

halx99 commented Aug 7, 2025

@aismann im just add test, I think we should add test first, then fix bug test in: https://github.com/NgVThangBz/axmol/tree/Fix-Label-Render fix in: https://github.com/NgVThangBz/axmol/tree/fix-Label-SDF-render

Ok I see. Plz add the fix also to this PR (title have to be changed?) Fix and a needed test on the same PR is faster and the expected result (the tester shows the known bug) The goal is the fix in this PR. Thanks.

agree

@aismann
Copy link
Contributor

aismann commented Aug 7, 2025

@NgVThangBz
You have changed (fix) a little bit more as expected by me.
Can you give some more information (screenshot?) what all is fixed with this PR?
Thanks.

@NgVThangBz
Copy link
Contributor Author

Here are some initial bugs I found, then fixed each bug

Size SDF not change when change size font
Font SDF changeSize

size text not correct when unBlod

Blod_UnBlud.mov

Outline enable->change size ->size no change and effect lost
Screenshot 2025-08-07 at 13 23 56

Glow enable->change size ->size no change and effect lost(both)
Screenshot 2025-08-07 at 13 24 13

@halx99
Copy link
Collaborator

halx99 commented Aug 7, 2025

does all bugs releated to SDF ?

@NgVThangBz
Copy link
Contributor Author

@halx99 some SDF and and some both

@aismann
Copy link
Contributor

aismann commented Aug 7, 2025

@NgVThangBz
Can you improve the tester?
Current situation:
image

I think the outline slider should only be enabled/shown if the Outline checkbox "checked"
If checked:
image

If NOT checked:
image

@NgVThangBz
Copy link
Contributor Author

@aismann im update it

@aismann
Copy link
Contributor

aismann commented Aug 7, 2025

@halx99
Should the Codacy static analysis not be the fist check ?
image

@halx99
Copy link
Collaborator

halx99 commented Aug 8, 2025

@halx99 Should the Codacy static analysis not be the fist check ? image

I can't control the check order

@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

@NgVThangBz
I have once again some improvements for the test:
I belive Outline and Glow cant be used on the same font toghether (can you improve the checkbox behavior again?)
Or is it a next issue and should fix?

@NgVThangBz
Copy link
Contributor Author

if Outline enable -> glow will disable (if enable) ,
same with Glow?

1 similar comment
@NgVThangBz
Copy link
Contributor Author

if Outline enable -> glow will disable (if enable) ,
same with Glow?

@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

if Outline enable -> glow will disable (if enable) , same with Glow?

I thick 2 radiobuttons be better as 2 checkboxes

@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

If you wish, the “title” of the test can also be more self-explanatory:
“TTF font: SDF vs. Normal”
And on the second line the issue number only (e.g.: "Issue xxx")

@NgVThangBz
Copy link
Contributor Author

NgVThangBz commented Aug 8, 2025

@aismann radiobuttons? outline, glow and normal?

Sounds good.

/Edit:
'normal' will 'uncheck' all font settings (checkboxes) too, right?

@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

@halx99
By the way:
I think its time to rename Menu entry "Node: Label - New API" to e.g. "Node: Label - SDF/Normal" or "Node: Label" only.
=> "New API" has not realy an useful info.

@NgVThangBz
Copy link
Contributor Author

NgVThangBz commented Aug 8, 2025

new UI

Screen.Recording.2025-08-08.at.14.10.21.mov

@halx99
Copy link
Collaborator

halx99 commented Aug 8, 2025

@halx99 By the way: I think its time to rename Menu entry "Node: Label - New API" to e.g. "Node: Label - SDF/Normal" or "Node: Label" only. => "New API" has not realy an useful info.

Yes, there is no old API in axmol, so just Node: Label, but not related to this PR

@halx99 halx99 modified the milestones: 3.0.0, 2.8.0 Aug 8, 2025
@halx99 halx99 linked an issue Aug 8, 2025 that may be closed by this pull request
@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

@NgVThangBz @halx99
what you think about this UI design:
image

or this:
image

@halx99
Copy link
Collaborator

halx99 commented Aug 8, 2025

new UI

Screen.Recording.2025-08-08.at.14.10.21.mov

I think it's ok, it just test case, so no need take much time to optimize ui layout

@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

new UI
Screen.Recording.2025-08-08.at.14.10.21.mov

I think it's ok, it just test case, so no need take much time to optimize ui layout

Correct. But we do it one time forever.
Feeling is better if the (test) UI is straight forward and clear too
@NgVThangBz
You can make it as you want.

@NgVThangBz
Copy link
Contributor Author

I have pushed the code

@aismann
Copy link
Contributor

aismann commented Aug 8, 2025

Resizing the font is working now
=> Some other bugs be there which not part of this PR

@NgVThangBz
Very good work, thanks.

@halx99
from my side, PR can be merge

@halx99 halx99 added the bug Something isn't working label Aug 8, 2025
@halx99 halx99 merged commit c49373d into axmolengine:dev Aug 8, 2025
15 checks passed
@halx99
Copy link
Collaborator

halx99 commented Aug 8, 2025

Merged, thanks @NgVThangBz

@halx99 halx99 linked an issue Aug 8, 2025 that may be closed by this pull request
@NgVThangBz NgVThangBz deleted the Fix-Label-Render branch October 17, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label render with Effect wrong Share Distance Field of Label work wrong

3 participants