Skip to content

Improve cmake win32 delayload settings #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halx99 merged 2 commits into from
Jul 14, 2025
Merged

Improve cmake win32 delayload settings #2595

halx99 merged 2 commits into from
Jul 14, 2025

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Jul 13, 2025 •
edited
Loading

Describe your changes

  • Fix link error when build win32 exe with cmake generator Ninja
  • Make msvc delay load mfmedia dlls also works with clang-cl or clang++

Issue ticket number and link

#2594

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

This was linked to issues Jul 13, 2025
Build fails due to unresolved lint dependency: lint-31.11.0.jar not found via Gradle #2586
Closed
Error building cpp-tests on windows as a cmake project, #2594
Closed
@halx99 halx99 removed a link to an issue Jul 13, 2025
Build fails due to unresolved lint dependency: lint-31.11.0.jar not found via Gradle #2586
Closed
@halx99 halx99 mentioned this pull request Jul 13, 2025
Closed
@halx99 halx99 added enhancement New feature or request bug Something isn't working labels Jul 13, 2025
@halx99 halx99 added this to the 2.7.1 milestone Jul 13, 2025
@halx99 halx99 force-pushed the improve-win32-delayload branch from 9865e55 to 3558df4 Compare July 14, 2025 00:20
@halx99 halx99 merged commit 7e537b9 into dev Jul 14, 2025
15 checks passed
@halx99 halx99 deleted the improve-win32-delayload branch July 14, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

2.7.1

Development

Successfully merging this pull request may close these issues.

Error building cpp-tests on windows as a cmake project,

2 participants

@halx99