-
-
Notifications
You must be signed in to change notification settings - Fork 253
Label fixes for wrapping, overflow and alignment #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for testing that. I'll look into it. |
|
@aismann How did you get the bounding box to appear just around that section, and not all labels? Which debug config option is it? Also, for the right alignment, I can't reproduce the issue. Can you explain step by step how you got that result where not text is displayed? |
|
I tested using the
But it can be the boundary box is not drawing correct (never checked) |
|
Both Win32/x64 debug and release versions end with the same result: (Used Screen2Gif to capture it) |
|
@aismann Is it still happening with the latest commit? |
Yes. Slider have to move slower and then you get the same behavior as I saw |
The slider starts at 52 out of 100 by default. Increasing it 1 at a time is still not showing what you're seeing. Is your cpp-tests modified in some way? |
|
@rh101 |
I downloaded that and ran it, and still cannot reproduce the issue. The dimensions of the label should not affect its visibility in this case, since they're still valid. Are you able to test the current
Thanks, I realized that earlier, since I had the debugging mode enabled the whole time, and forgot that the default tests also draw a bounding box. |
|
Maybe some hardware settings? @halx99 |
Try delete |
Thank you for testing that. This PR will stay in draft mode until I can figure out what is causing that issue. |
@halx99 |
Improve method names
|
@rh101 |
I tested it on Android as well, and it's working perfectly, and I still cannot reproduce the issue on my own Windows 10 PC, so I'm still looking into all possible reason why it may happen when running on your PC. There is a clamping issue that I need to fix, so I'll commit more changes soon. |
Plz show the slider value also on the screen. And the font size maybe also. |
Use letter offsets for more accurate clamping
Both implemented, so if and when you have some time, please test out the latest builds. |
|
Tested. Works as exepected now. Can be merged now. Short info: |
|
@rh101 |
Excellent! Anyhow, once that is done, then this PR should be good to go, unless anyone finds any other issues that I may have missed.
Possibly, but I'm not sure. It definitely doesn't keep updating the content every loop when there are no changes, so at least it won't use resources for no reason. |
|
@rh101 Only a hold in mind: |
I checked, it's also correct:
|
|
I played a little bit around with the It crashed pressing axmol.version: axmol-2.6.1-59c544c Try with the 2.6.1 release: axmol.version: axmol-2.6.1-f4855f6 |









Describe your changes
This PR is an attempt to address several issues:
_lineBreakWithoutSpacesisfalseI've tested as much as I've been able to, including the tests in cpp-tests, but it would be good if these changes are tested by others on their projects to see if there are any issues.
Label test vertical slider flipped the opposite direction so that 0% is down the bottom and 100% is up the top.
Issue ticket number and link
#2503
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR