running tests locally, 1 test fails

67 passing (4s)
  1 failing

  1) supports http with nodejs
       should support max content length:

      Uncaught AssertionError [ERR_ASSERTION]: 'Request failed with status code 400' == 'maxContentLength size of 2000 exceeded'
      + expected - actual

      -Request failed with status code 400
      +maxContentLength size of 2000 exceeded

      at Timeout._onTimeout (test/unit/adapters/http.js:

the same test fails on the v0.x branch

@jasonsaayman Please take a look when you get a chance.

@thatguyinabeanie you have pushed a compiled file, can you please remove that? thanks

@thatguyinabeanie you have pushed a compiled file, can you please remove that? thanks

all set

Hi @mhassan1 please review the changes if you get a chance.
Thanks @thatguyinabeanie for taking care of this

The typing changes are missing from this PR; see #6818.

Thanks, @thatguyinabeanie, for the fix, and @jasonsaayman and @mhassan1 for reviewing!

Is this scheduled for release soon, or should we wait for the typing changes to be merged first?

Also, I noticed that #6833 by @mhassan1 doesn’t include the strict equal comparison @jasonsaayman included in this PR. Is that intentional, or should we open an issue for it?

@mhassan1 thanks for pointing that out!

@jasonsaayman i opened a new PR that adds the types #6849

thanks