test(transform): add test case for issue 5853 on response type to 'json' #5901
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f76e08 to
fb31986
Compare
fb31986 to
a250376
Compare
Contributor
Author
|
Hi,
Thanks so much for the feedback!
I formatted the second argument and pushed my changes.
I'm not sure if I did the git correctly.
Since there were some other changes, I rebased according to v1.x, then
committed & pushed my changes.
The only changes I intended to make is in test/specs/transform.spec.js🙂
Best,
Naron
…On Thu, Sep 21, 2023 at 6:26 AM JozefKsl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/specs/transform.spec.js
<#5901 (comment)>:
> @@ -197,4 +197,34 @@ describe('transform', function () {
done();
});
});
+
+ it('should return response.data as parsed JSON object when responseType is json', function(done){
nitpick, please format the second argument
function (done) { ... }
—
Reply to this email directly, view it on GitHub
<#5901 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARJXJXU3THJN5STVGUIPI53X3QI6ZANCNFSM6AAAAAA43K27QA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Hi, @naronchen! This PR has been published in v1.8.0 release. Thank you for your contribution ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case to address issue #5853.
This test ensures that setting responseType to 'json' handles the response as expected.
The issue was regarding v0.27.2, but I thought I would just write a test for it as its not tested. Just as my very first open source pull request :)