Skip to content

Conversation

@gligorkot
Copy link
Contributor

Fixes #5358 by adding dist cjs for node and browser to the package exports

@gligorkot gligorkot changed the title fix: Fix package exports fix(package): Fix package exports Jul 12, 2023
@kKen94
Copy link

kKen94 commented Jul 19, 2023

@gligorkot what are we waiting for?

@gligorkot
Copy link
Contributor Author

@gligorkot what are we waiting for?

@kKen94 I'm not a maintainer, we need a library maintainer to review, approve and merge the PR.

@gligorkot
Copy link
Contributor Author

@DigitalBrainJS any chance this could be reviewed please? 🙏

@nbmendez
Copy link

nbmendez commented Jan 8, 2024

Hello @Cadienvan, is it possible to merge this PR please ? Thanks

@Cadienvan
Copy link
Contributor

@nbmendez I'm not a maintainer even if I'd love to! @DigitalBrainJS need help?

@yishayh
Copy link

yishayh commented Jan 31, 2024

Hello @DigitalBrainJS, is it possible to merge this PR please ? Thanks

@jasonsaayman jasonsaayman added the review:follow-up Maintainer to follow up label Dec 14, 2024
@jasonsaayman
Copy link
Member

@gligorkot i cant update this branch can you rebase pls

@jasonsaayman jasonsaayman added this to the v1.8.0 milestone Dec 14, 2024
@jasonsaayman jasonsaayman self-assigned this Dec 14, 2024
@gligorkot
Copy link
Contributor Author

@jasonsaayman done a merge, hopefully that's ok. Let me know if you need me to specifically rebase it and I can do that.

@jasonsaayman jasonsaayman added state::ready-to-merge and removed review:follow-up Maintainer to follow up labels Dec 21, 2024
@jasonsaayman jasonsaayman removed their assignment Dec 21, 2024
@max107
Copy link

max107 commented Jan 10, 2025

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr::fix PR that fixes a bug priority::medium A medium priority v1.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't import cjs

10 participants