adding create instance config type as AxiosRequestConfig does not if always#4191
Closed
Edmu wants to merge 1 commit intoaxios:masterfrom
Closed
adding create instance config type as AxiosRequestConfig does not if always#4191Edmu wants to merge 1 commit intoaxios:masterfrom
Edmu wants to merge 1 commit intoaxios:masterfrom
Conversation
…fore were not allowing to pass get, post etc. records
ghost91-
reviewed
Oct 21, 2021
Member
|
Seems this has already been addressed by another pull request, please re-open if I am mistaken 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4184
Allows to pass different type of axios config (modified AxiosRequestConfig) for axios.create. So code example below does not throw typescript error.
axios.create({ ..., headers: { get: { 'common-header-for-get': 'value' }, 'some-header-for-all-methods': 'value' }, });which works fine if using javascript lib version w/o typescript.