Returned error treated when requesting uncommon URL#3544
Merged
jasonsaayman merged 6 commits intoaxios:masterfrom Mar 7, 2022
Merged
Conversation
|
I suggest that keep the URL validating behavior the same in both node an browser. |
Contributor
Author
|
If I understand, this URL validating behavior (error messages) must be present too, in axios requests made by client (browser). Would be this? |
Contributor
Author
|
Currently, the URL validating are these: Malformed URL:
Unsupported protocol:
|
Contributor
Author
|
Hello @buyan302, I simplely, used the same logic of my new error messages from node on Waiting for your feedback. Thanks. |
wenderjean
reviewed
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the irrelevant error returned when requesting uncommon URL - Open Issue #3509
When axios request to an illegal URL like "tel:484-695-3408", the error message is irrelevant.
So, I fixed this, validating the "path" property from "parsed" object, cheking if it is null, throwing an error message: "Malformed URL". And I checked too, if the URL protocol is supported (HTTP or HTTPS) throwing a message: "Unsupported protocol ".