Compatible with follow-redirect aborts the request #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for unpinning (see also #2691). |
|
The error message might not necessarily be a constant though; let's think of a contract that we can sustain. Such as an error code or so. |
Contributor
Author
|
@RubenVerborgh Yeah, waiting for your good news about the error code. |
|
@chinesedfan As as of |
Contributor
Author
|
@RubenVerborgh Updated with the error code. Thanks for your quick response. |
RubenVerborgh
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #1804. Closed #2691.
follow-redirects was locked to 1.5.10 in #1993 and was reverted unintentionally in #1816. And #2570 locked it again.
The reason is that from follow-redirects@1.6.0, the request will be aborted when redirecting. See follow-redirects/follow-redirects@7a0a683. Then axios can't emit the error, which results in test case "should support max redirects" failed.