Skip to content

Revert finally as then #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yasuf merged 2 commits into from
Jan 22, 2020
Merged

Revert finally as then #2683

yasuf merged 2 commits into from
Jan 22, 2020

Conversation

@chinesedfan
Copy link
Contributor

@chinesedfan chinesedfan commented Jan 21, 2020

don't make users think every Promise implementation has a finally method already. It is still on draft stage.

Fixed #2593.

@yasuf yasuf merged commit 7df84a7 into axios:master Jan 22, 2020
@axios axios locked and limited conversation to collaborators May 3, 2020
@jasonsaayman jasonsaayman added this to the v0.20.0 milestone May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.20.0

Development

Successfully merging this pull request may close these issues.

Revert changes about finally

3 participants

@chinesedfan @jasonsaayman @yasuf