Skip to content

Conversation

@galkin
Copy link
Contributor

@galkin galkin commented Jan 15, 2020

This pull should fix #2665 and very similar to #1129

@chinesedfan
Copy link
Contributor

@galkin Thanks for your fix and it looks good to me. Forgive that I am not an HTTP expert. I want to ask a question before approving. Does it mean HEAD requests will always have no content? At least, MDN says that.

@galkin
Copy link
Contributor Author

galkin commented Jan 27, 2020

@chinesedfan, yes, according to http specification HEAD requests always have not body, but headers should be equals to GET method.

@chinesedfan
Copy link
Contributor

@galkin Would you mind updating the branch with the latest master? Looks like your PR is based your master branch, so I can't update it by myself.

@galkin
Copy link
Contributor Author

galkin commented Feb 15, 2020

@chinesedfan, done.

@chinesedfan
Copy link
Contributor

@galkin Damn it. I just fixed a test bug, #2748. Can I beg you again?

@galkin
Copy link
Contributor Author

galkin commented Feb 15, 2020

@chinesedfan, done.

@chinesedfan chinesedfan changed the title Fixing issue for HEAD method and gziped repsonse #2665 Fixing issue for HEAD method and gziped repsonse Feb 15, 2020
@chinesedfan chinesedfan merged commit 12e00b8 into axios:master Feb 15, 2020
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Axios crashes on HEAD method and gziped repsonse

2 participants