Fixing unit test failure in Windows OS #2601
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinesedfan
suggested changes
Jan 31, 2020
Contributor
chinesedfan
left a comment
There was a problem hiding this comment.
Would you mind follow suggestions from @a631807682 or #2594 (comment)?
chinesedfan
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2594.
Root cause description:
Test case 'should pass errors for a failed stream' failed because of the difference between OS systems. In Windows, path does use '/' as delimiter.
Code change description:
Use "__dirname" which is the absolute path of the directory containing the currently executing file to construct the 'do not exist' folder to keep consistency between different OS systems.