Using Node 10 on CI #2138
Using Node 10 on CI #2138
Conversation
|
It does seem like quite a harmless change, especially since there is a PR on bundlesize to fix it. |
| @@ -1,6 +1,6 @@ | |||
| language: node_js | |||
| node_js: | |||
| - node | |||
There was a problem hiding this comment.
Any reason why we can't use 12? Or is 12 explicitly what is breaking this?
I'd like to stay on LTS since the end of life for 11 is quite soon (2019-06-01)
EDIT: sorry, hastily read this! let me look into this, as I am still hesitant to move to 11.
There was a problem hiding this comment.
@emilyemorehouse it can be reverted once the downstream issue is fixed. Another option would be to use a package-lock or npm-shrinkwrap to upgrade brotli-size
If staying on an LTS release is a priority, I think 10 would work as well and will be supported until April 2021
There was a problem hiding this comment.
Approve of using node 10 for now.
There are several packages still can not used with node 12. And we should keep the CI working at least. Otherwise contributors will be confused.
There was a problem hiding this comment.
Changed to 10 in 0430711, looks like CI is still working
|
at least 1,327,670 emails are already sending 😄 Thanks @github :) |
What's blocking this merge? |
|
@AAllport I think nothing but time. I understand the essence of next axios release and this is really annoying for GitHub notification. But let's not to forget this is an opensource project. OSS maintainers, even by doing best efforts can't always dedicate full time on the project. |
|
Sorry to ping again @emilyemorehouse . It looks like GitHub is now sending emails to everyone that uses |
|
CI is passing as-is now (and a release has been made). Can this be closed? |
|
Ah ok, if it's passing now then this isn't necessary |
Temporarily downgrades NodeJS because a nested dependency (
bundlesize@0.17.1 > brotli-size@0.0.1 > iltorb@1.3.10) does not support Node 12. This can probably be reverted once siddharthkp/bundlesize#299 is merged. Alternatively, a package-lock.json or npm-shrinkwrap.json can be used to upgradebrotli-sizeto 0.1.0.