Skip to content

Conversation

@oleduc
Copy link

@oleduc oleduc commented Feb 20, 2019

As described in issue #1718 as of beta-0.19 custom configuration is broken which breaks a plugin that we are using (3846masa/axios-cookiejar-support). This pull request aims to restore the behavior that was present in 0.18.0 without adding a new feature (unlike #1831)

@oleduc
Copy link
Author

oleduc commented Apr 23, 2019

@emilyemorehouse I would greatly appreciate if someone could have a look at this :)

@rafaelrenanpacheco
Copy link
Contributor

@emilyemorehouse hello! What's the status on this PR? Look's like there are some conflicts and the author didn't fix it so far. Will you work on this conflicts or would you like a fresh new PR regarding this fix? Lot's of axios plugins are crashing in 0.19 because the custom config was removed.

@jasonsaayman
Copy link
Member

@oleduc please, can you remove the dist folder from the pull request?

@jasonsaayman
Copy link
Member

@rafaelrenanpacheco if you want to rather put in a pull request that does not include the dist folder, please do so, then at me in that pull request. I can then close this one and reference to that one.

@rafaelrenanpacheco
Copy link
Contributor

Hey @jasonsaayman! Here is the new PR: #2207

Thanks!

@marosivanco
Copy link

What are the plans for merging and releasing of this PR? In which version will it be released?

@rafaelrenanpacheco
Copy link
Contributor

This fix was merged at #2207

@felipewmartins I think this PR can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants