Added Response header access instructions #1901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2018
chinesedfan
suggested changes
Feb 25, 2020
Contributor
Author
|
@chinesedfan Thanks for the review. I've added a note about the use of bracket notation. I hope that's better. I'm tempted to even place a link to the MDN page on HTTP headers. Overkill? Btw, you might want to bring this PR up to date with |
chinesedfan
approved these changes
Feb 26, 2020
Contributor
There was a problem hiding this comment.
@unguul Don't worry. You did the right thing by updating with master. And really appreciate for quick response to such a stale pull request. MDN link can be ignored.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Response header access instructions to the docs.
This should fix #1606 and maybe others.
I suspect the confusion comes from the fact that (most of) everything else offers dot notation access but headers come along with dashes and it breaks.