Skip to content

Adding responseEncoding to mergeConfig#1745

Merged
chinesedfan merged 3 commits intoaxios:masterfrom
ehrhart:master
Feb 15, 2020
Merged

Adding responseEncoding to mergeConfig#1745
chinesedfan merged 3 commits intoaxios:masterfrom
ehrhart:master

Conversation

@ehrhart
Copy link
Copy Markdown
Contributor

@ehrhart ehrhart commented Aug 20, 2018

responseEncoding has been implemented via #869, but the property hasn't been added in mergeConfig and thus isn't recognized.

This pull request fixes this issue by adding responseEncoding as a valid property in mergeConfig.

Fixes #1561
Related to #869

Copy link
Copy Markdown
Contributor

@Alanscut Alanscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for handling it so long, please resolve the conflict

@ehrhart ehrhart requested a review from Alanscut December 19, 2019 10:00
Copy link
Copy Markdown
Contributor

@Alanscut Alanscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chinesedfan chinesedfan merged commit 17a9671 into axios:master Feb 15, 2020
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

charset latin1 not working

3 participants