chore: ignore package-lock.json#1458
Merged
nickuraltsev merged 1 commit intoaxios:masterfrom Apr 7, 2018
Merged
Conversation
Contributor
|
Sure, let's ignore it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So
package-lock.jsonis a funny thing. It locks the exact version of npm dependencies down, ensuring that every build gets the same exact deps.On the surface, this sounds great. If you're an end-user building a web app, it's fantastic. However, if you're a library author it's not so great. When end users
npm install axios, they're going to get the latest version of transitive dependencies in accordance to semver, ignoring what's actually in our package-lock.json. This means that while things are locked down and cheery in this repository, end users may actually be getting errors.This is something we debated intensely at Google, and to be honest - there are good arguments for both. Since there's currently no package-lock.json in this repo, I'm choosing to just go ahead and ignore it. I'd love to hear others opinions!