Skip to content

chore: switch to job summary#10911

Merged
jasonsaayman merged 1 commit into
v1.xfrom
chore/swtich-to-commentor
May 19, 2026
Merged

chore: switch to job summary#10911
jasonsaayman merged 1 commit into
v1.xfrom
chore/swtich-to-commentor

Conversation

@jasonsaayman

@jasonsaayman jasonsaayman commented May 19, 2026

Copy link
Copy Markdown
Member

Summary

This pull request updates the bundle size workflow to use a newer version of the bundle size action and improves how the bundle size report is presented. The main changes focus on upgrading dependencies, adjusting permissions, and enhancing the workflow summary output.

Workflow improvements:

  • Upgraded the axios/bundle-size GitHub Action from version 0.1.1 to 0.2.0 in .github/workflows/bundle-size.yml, which may include bug fixes and new features.
  • Removed the explicit pull-requests: write permission from the workflow, potentially reducing unnecessary permissions.

Reporting enhancements:

  • Removed the comment-pr and github-token inputs, so the action no longer comments directly on pull requests. Instead, a new step was added to append the bundle size report (bundle-size-comparison.md) to the GitHub Actions summary, making the report more accessible in the workflow run summary.

Linked issue

N/A

Changes

  • Post output to the action summary report.

Checklist

  • Tests added or updated (or N/A with reason)
  • Docs / types updated if public API changed (index.d.ts and index.d.cts)
  • No breaking changes (or called out explicitly above)

Summary by cubic

Switch bundle-size reporting from PR comments to the GitHub Actions job summary and upgrade axios/bundle-size to 0.2.0. Drops the unnecessary PR write permission.

  • Dependencies

    • Bump axios/bundle-size from 0.1.1 to 0.2.0.
  • Refactors

    • Stop commenting on PRs; remove pull-requests: write, comment-pr, and github-token.
    • Append the generated report to the Actions job summary.
    • Docs: Update /docs/ci/bundle-size.md to point to the job summary instead of PR comments.
    • Testing: Workflow-only; verify in CI run. No app code tests needed.
    • Semantic version impact: None for packages (infra-only); treat as patch if releasing.

Written for commit 9cb5397. Summary will update on new commits. Review in cubic

@jasonsaayman jasonsaayman self-assigned this May 19, 2026
@jasonsaayman jasonsaayman added priority::medium A medium priority commit::chore The PR is related to a chore labels May 19, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@jasonsaayman jasonsaayman merged commit e63e48c into v1.x May 19, 2026
26 checks passed
@jasonsaayman jasonsaayman deleted the chore/swtich-to-commentor branch May 19, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::chore The PR is related to a chore priority::medium A medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant