chore: switch to job summary#10911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the bundle size workflow to use a newer version of the bundle size action and improves how the bundle size report is presented. The main changes focus on upgrading dependencies, adjusting permissions, and enhancing the workflow summary output.
Workflow improvements:
axios/bundle-sizeGitHub Action from version0.1.1to0.2.0in.github/workflows/bundle-size.yml, which may include bug fixes and new features.pull-requests: writepermission from the workflow, potentially reducing unnecessary permissions.Reporting enhancements:
comment-prandgithub-tokeninputs, so the action no longer comments directly on pull requests. Instead, a new step was added to append the bundle size report (bundle-size-comparison.md) to the GitHub Actions summary, making the report more accessible in the workflow run summary.Linked issue
N/A
Changes
Checklist
index.d.tsandindex.d.cts)Summary by cubic
Switch bundle-size reporting from PR comments to the GitHub Actions job summary and upgrade
axios/bundle-sizeto 0.2.0. Drops the unnecessary PR write permission.Dependencies
axios/bundle-sizefrom 0.1.1 to 0.2.0.Refactors
pull-requests: write,comment-pr, andgithub-token./docs/ci/bundle-size.mdto point to the job summary instead of PR comments.Written for commit 9cb5397. Summary will update on new commits. Review in cubic