Conversation
commit: |
thesollyz
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #286
Vitest 4.1.0 changed suite hook signatures for
beforeAll/afterAll: the first arg is now fixture context, and the internal suite object moved to the second arg. That brokeaxiom eval, which usesbeforeAll(async (suite) => ...)and failed withFixtureParseError.This PR makes eval hooks work on both Vitest 4.0.x and 4.1.x by normalizing the hook arguments in one small compatibility wrapper, while keeping the actual hook logic in explicit
handleBeforeAll/handleAfterAllfunctions. It also makes the afterAll task status checks safer withtask.meta.case?.status.Context:
Vitest release: https://github.com/vitest-dev/vitest/releases/tag/v4.1.0
Upstream change: vitest-dev/vitest#9572
Related follow-up/error text: vitest-dev/vitest#9786
Note
Medium Risk
Moderate risk because it changes how
beforeAll/afterAllhooks receive the Vitest suite object, which can affect evaluation initialization/finalization and reporting if the compatibility shim is wrong.Overview
Fixes
axiom evalrunning under Vitest 4.1 by adding a small compatibility wrapper (withCompatibleSuiteHook) that normalizesbeforeAll/afterAllhook arguments across Vitest versions and refactors the hook bodies intohandleBeforeAll/handleAfterAll.Also hardens end-of-suite case counting by treating
task.meta.caseas optional (case?.status) to avoid crashes when case metadata is missing.Written by Cursor Bugbot for commit c63e5f2. This will update automatically on new commits. Configure here.