Skip to content

dynamic custom elements loose react refs, never connect and do not update props #778

@AndyOGo

Description

@AndyOGo

Are you reporting a bug or a feature?

  • Bug
  • Feature

Expected Behavior

All extended built-ins should connect if wrapped by withReact and should batch attributes by setProps.

Actual Behavior

<td is="axa-td"> does never call connectedCallback and attributes aren't batched by setProps call from withReact.

Edit:
I'm sure the issue is that the withMonkeyPatches HOC is always included.
Instead it should only be composed if it is really needed, especially if a custom-element does not define a local-DOM it get's into the way.

https://github.com/axa-ch/patterns-library/blob/eeaaf2e59207f5af09ac12b974aa78b715d460fa/src/js/abstract/hocs/index.js#L25-L27

Steps to Reproduce the Problem

  1. https://github.com/axa-ch/patterns-library-examples/pull/16

Specifications

  • Browser: Latest Chrome
  • Browser Version:
  • Node Version:
  • NPM Version:
  • Platform:

Failure Logs

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions