require TransportStream is Sync#917
Merged
Merged
Conversation
jmt-lab
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #928
Description of changes:
Streams returned from tough cannot be shared between threads because they are
!Sync. As it turns out, all of the transports I'm aware of (the three in tough itself, and the one I've recently written to read from ZIP archives) return streams that are alreadySync, but they can't be used in other parts of the Rust ecosystem that requireSyncstreams. (In my case I am currently butting up againstdropshot::BodyrequiringSyncfor a service that is proxying targets from a TUF repository.)This stems from the use of
futures::stream::BoxStreaminternally, whose type does not specifySend. Replacing.boxed()withBox::pinis sufficient.This is a breaking change, but not one I expect most consumers will need to be concerned with.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.