Fix: max_targets_size in load_targets#884
Merged
Merged
Conversation
Contributor
|
Heya @ecpullen! Thanks for submitting this! Wow, that variable shadowing is easy to miss. Nice catch. This LGTM, just waiting for the CI to run. |
Contributor
|
Looks like we may just need to run |
9e8e63c to
a08e6c1
Compare
Contributor
Author
|
@cbgbt Fixed the formatting and ensured clippy passes. Thanks for the quick follow-up. Let me know if there's anything else. |
cbgbt
approved these changes
Jun 12, 2025
Contributor
Author
|
Hi @cbgbt, Is there anything I can do to help this get merged and released? |
Contributor
|
LGTM |
jmt-lab
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#883
Description of changes:
I changed the
max_targets_sizethat is used for loading the top leveltargets.jsonmetadata file tomax_targets_file_size.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.