tough: flush file explicitly in cache#874
Merged
Merged
Conversation
Signed-off-by: Sam Berning <bernings@amazon.com>
jmt-lab
approved these changes
Apr 21, 2025
cbgbt
approved these changes
Apr 21, 2025
This was referenced Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#872
Description of changes:
While tracking down the issues in Github actions observed in #872, @jmt-lab pointed out that a
tokio::fs::Fileshould be flushed after writing, or the file may not close on exit. See tokio's docs on this.This might be causing the test failures that we're seeing, as after the
tuftool clonecommand exits, the write may not have finished for1.root.jsonas it's the last file that we copy.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.