Feature flag for fetching from ASM#133
Closed
Benbentwo wants to merge 9 commits intoawslabs:masterfrom
Closed
Conversation
Add Print Statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue #67
Description of changes:
SSOSYNC_LOAD_ASM_SECRETSdefault:true- this variable when set to false will not need any ASM Secrets, so long as the environment variables are set it will try to run. This is useful for deploying the app using SSM or any other secret -> env mapping (deployed to kuberentes for example)This can help avoid the need to fetch from ASM all together. I also updated to 1.19 to fix unit tests