-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added RekognitionDetectOnlyPolicy to SAM #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- To fix issue aws#245 and allow Detect* Rekognition permissions to be used without a collection ID. - I'm not too familiar with this code base, so I based my changes on where RekognitionNoDataAccessPolicy appeared. - So in the docs json, the samtranslator json and in the tests and examples - If this passes all of Travis's tests, I'll come back and fix the examples.
|
I believe that Travis Failure is fixed with #570. You'll need to merge it in first and then rebuild. |
|
Hi @RobRoseKnows thanks for this! Looks like you made the changes against the master branch which has some conflicts with the develop branch. Could you checkout the develop branch and make the changes there? You'll notice that the policy templates json in |
|
@brettstack Whoops, didn't see the |
|
Sorry for all the notifications, I had trouble with testing locally at first so I let Travis do it. Did get them passing now though. |
keetonian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! Thank you for the contribution!
|
Is there a public timeline for when |
|
We don't share exact dates for releases, but I can say that we're planning a release "soon." We're aware of the hackathon deadline, so we're planning upcoming releases accordingly. Thanks for participating in the hackathon! 😊 |
RekognitionNoDataAccessPolicydo not support specificcollectionidresources #245 and allow Detect* Rekognition permissions to be usedwithout a collection ID.
where RekognitionNoDataAccessPolicy appeared.
examples.
Issue #, if available: #245
Description of changes: Added a new policy template to allow for Rekognition DetectEtc calls without collection id.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.