feat: standardize inbox API parameters with backward compatibility#42
Closed
yubing744 wants to merge 1 commit into
Closed
feat: standardize inbox API parameters with backward compatibility#42yubing744 wants to merge 1 commit into
yubing744 wants to merge 1 commit into
Conversation
- Change terminal_id from TerminalId to str with Path() validation - Rename status parameter to message_status with alias='status' for backward compatibility - Update related tests to reflect parameter changes - Apply proper code formatting This change improves API design consistency while maintaining full backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/claude-code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes the inbox API parameters while maintaining full backward compatibility.
What changed
TerminalIdtostrwithPath()validation for better type safetystatustomessage_statuswithalias="status"for backward compatibilityWhy this PR is needed
Backward Compatibility
statusquery parameter continues to work via FastAPI aliasFiles changed
src/cli_agent_orchestrator/api/main.py- Core API parameter changestest/api/test_inbox_messages.py- Updated test formattingTest plan
This change improves the API design while ensuring no disruption to existing users.
🤖 Generated with Claude Code
via Happy