feat(iam): CompositePrincipal and allow multiple principal types#1377
Merged
feat(iam): CompositePrincipal and allow multiple principal types#1377
Conversation
Relax constraint on IAM policy statement principals such that multiple principal types can be used in a statement. Also, the `CompositePrincipal` class can be use to construct `PolicyPrincipal`s that consist of multiple principal types and conditions. Backfill missing addXxxPrincipal methods. Deprecate (soft) `Anyone` in favor of `AnyPrincipal`.
RomainMuller
previously approved these changes
Dec 17, 2018
Contributor
Author
|
@rix0rrr I need you to also take a look (IAM library...) |
rix0rrr
reviewed
Dec 17, 2018
rix0rrr
reviewed
Dec 17, 2018
rix0rrr
approved these changes
Dec 17, 2018
RomainMuller
approved these changes
Dec 17, 2018
Contributor
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax constraint on IAM policy statement principals such
that multiple principal types can be used in a statement.
Also, the
CompositePrincipalclass can be use to constructPolicyPrincipals that consist of multiple principal typesand conditions.
Backfill missing addXxxPrincipal methods.
Deprecate (soft)
Anyonein favor ofAnyPrincipal.Fixes #1201
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.