Expose flags for max-pods-calculator to use a configurable max pods ceiling#759
Expose flags for max-pods-calculator to use a configurable max pods ceiling#759a7i wants to merge 1 commit intoawslabs:masterfrom
Conversation
08ca1b1 to
5761c9a
Compare
|
@overdrive3000 this is a pretty small change, can this be reviewed? |
files/max-pods-calculator.sh
Outdated
There was a problem hiding this comment.
Apologies for not looking at this PR earlier.
Can we use a combination of this PR to achieve this? You can do the min_number logic on whatever invokes this script ?
There was a problem hiding this comment.
No worries @suket22
I'm not sure what SHOW_MAX_ALLOWED would do here
|
+1 for having a ceiling but also the option to, within the script, to provide an override. |
|
@cartermckinnon would you please provide a reason why this was closed and why it's not a good change? |
|
I'm just going through and closing stale PR's, this one needed a rebase. I'm not really against the change if you're still interested, but there's been no other engagement and I assume you've solved this on your end by now? |
Issue #, if available:
Description of changes:
Provide the ability to pass in the ceiling for max-pods instead of relying on the default values for low/high cpu count.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.