Skip to content

Upgrade 1.24 to kernel-5.10#1118

Merged
cartermckinnon merged 6 commits intomasterfrom
upgrade-1.24-to-5.10
Feb 7, 2023
Merged

Upgrade 1.24 to kernel-5.10#1118
cartermckinnon merged 6 commits intomasterfrom
upgrade-1.24-to-5.10

Conversation

@cartermckinnon
Copy link
Copy Markdown
Contributor

@cartermckinnon cartermckinnon commented Dec 7, 2022

Issue #, if available:

Closes #857

Description of changes:

This upgrades the 1.24 AMI's to use the 5.10 kernel line.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

I did make 1.23, confirmed it's still on 5.4; then did make 1.24 and confirmed it's now on 5.10.

@camrakin TODO

@cartermckinnon cartermckinnon added the kernel Related to the Linux kernel. label Dec 7, 2022

sudo chmod -R a+x $TEMPLATE_DIR/bin/
sudo mv $TEMPLATE_DIR/bin/* /usr/bin/

Copy link
Copy Markdown
Contributor Author

@cartermckinnon cartermckinnon Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these in a new provisioner so they're available during upgrade_kernel.sh.

@cartermckinnon cartermckinnon mentioned this pull request Dec 7, 2022
@mhulscher
Copy link
Copy Markdown

Perhaps this is out of place, but I'd like to ask anyway. I've been using 5.10 and 5.15 kernels w/ these AMIs for over a year, but I noticed that the GPU AMI was not compatible with these kernels. AFAIK the nvidia-gpu-operator was not able to initialize nodes. Is this being considered as well?

@cartermckinnon
Copy link
Copy Markdown
Contributor Author

@mhulscher I don't think the GPU operator specifically supports Amazon Linux at this point, though that support is being worked on as far as I know. My understanding is that the operator installs pre-compiled kernel modules, and I assume you'd run into issues if there was no such module compiled against the 5.10/5.15 headers. Just a guess; I'd probably open an issue with the operator maintainers.

@learhy
Copy link
Copy Markdown

learhy commented Jan 10, 2023

@cartermckinnon any updates on this PR? Do you have an estimate as to when it will land in 1.24?

Thanks!

@RainofTerra
Copy link
Copy Markdown

We're currently building our own AMI that pulls in this change so we'd love to see it merged.

I'll probably file a separate issue for this, but it would be nice for 5.15 to be included as an option that we can pick at build time just so I don't have to maintain a (minor) fork to test later kernels on our nodes.

@cartermckinnon
Copy link
Copy Markdown
Contributor Author

@RainofTerra yep, I plan to make that change once we get this merged 👍

@cartermckinnon
Copy link
Copy Markdown
Contributor Author

We're still working on some performance testing (we were delayed around the holidays, apologies). We don't expect to find any notable differences between 5.4 and 5.10, we're just trying to get a baseline and cover our bases. I hope to share as much of that analysis as we can here. My expectation is this will be merged and released on the order of weeks, not months; I'll update here as possible.

@stacybird
Copy link
Copy Markdown

can't wait to see this merged. :-)

@bryantbiggs
Copy link
Copy Markdown
Contributor

oh dang - is it happening?!

@learhy
Copy link
Copy Markdown

learhy commented Feb 6, 2023

Hurrah!

@camrakin
Copy link
Copy Markdown
Contributor

camrakin commented Feb 7, 2023

We’re ready to merge this! We compared the 5.4 and 5.10 kernels’:

  1. Conformance, using Kubernetes' end-to-end integration test suite, the aws-k8s-tester, and long-running synthetic workloads.
    1. We observed no functional difference between the two kernels when it comes to Kubernetes.
  2. Performance, using stress-ng and netperf.
    1. We observed both marginal increases and decreases across the test cases; overall representing equivalent performance.

We’re excited for users to leverage the features of 5.10 in their clusters! We encourage users to monitor their workloads for differences when upgrading, and to open an issue here if something seems off.

@cartermckinnon cartermckinnon merged commit ccf5b15 into master Feb 7, 2023
@cartermckinnon cartermckinnon deleted the upgrade-1.24-to-5.10 branch February 7, 2023 00:02
@learhy
Copy link
Copy Markdown

learhy commented Feb 7, 2023

Thanks, all!

@stevehipwell
Copy link
Copy Markdown
Contributor

@cartermckinnon based on the release notes am I correct in thinking this didn't make it into v20230203?

@dims
Copy link
Copy Markdown
Contributor

dims commented Feb 7, 2023

xref - aws/containers-roadmap#1570

@cartermckinnon
Copy link
Copy Markdown
Contributor Author

@stevehipwell Correct, this will land in the next release. Should be in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Related to the Linux kernel.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Linux Kernel to 5.10

10 participants