fix: properly evaluate process.env.AUTO_WEBP#195
Closed
toredash wants to merge 1 commit intoaws-solutions:masterfrom
Closed
fix: properly evaluate process.env.AUTO_WEBP#195toredash wants to merge 1 commit intoaws-solutions:masterfrom
toredash wants to merge 1 commit intoaws-solutions:masterfrom
Conversation
Contributor
|
Thanks for your contribution @toredash , and we are already aware of this issue, and we will fix this one on the next release. |
Author
|
@beomseoklee should this PR be closed then, or do you wish to keep it open ? |
mik3y
added a commit
to mik3y/serverless-image-handler
that referenced
this pull request
Jul 12, 2020
Contributor
|
@toredash |
thisismana
pushed a commit
to thisismana/serverless-image-handler
that referenced
this pull request
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
process.env.AUTO_WEBP isn't properly evaluated. CloudFormation file sets this ENV to either "Yes" or "No", but the code only checks if the ENV variable is present or not.
Change was introduced with the bug present in #152
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.