This repository was archived by the owner on Jan 22, 2026. It is now read-only.
add support for hpc7g family of images#1
Merged
lipovsek-aws merged 1 commit intoaws-samples:mainfrom Dec 10, 2023
Merged
Conversation
Contributor
|
Sorry for late response, can you please rebase and I'm happy to merge. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
3e5faf3 to
521efdc
Compare
Contributor
Author
|
Yes of course! All set. I also ensured they were in alphabetical order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to eksctl-io/eksctl#6743 to update the config here to allow support for the new hpc7g family of ARM images.
Note that this should not be merged yet, as the image family does not appear to work with EFA. I cannot see the source code of the build, but I can show you a working vs. not working example. Here is the result of using this branch with the
im4gn.16xlargeinstance (also ARM) and it works:And for comparison, using the same logic / setup (aside from the instance type / resources) we cannot find an EFA plugin for
hpc7g.16xlargeAnd the containers go into CrashLoopBackoff. I'm including this here in case anyone that reads this repository has access to the private repository where the plugin code is hosted. We have a good debugging setup from the above - two arm images, where it works for one but not for the other! So my suggestion would be to find the plugin code that asserts that the devices exist, and assess the logic in the context of the different ARM images. Likely whatever detail is different is leading to this result.
Thanks for your help!