generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 185
fix(logger): improve e2e test resilience by grouping logs by level #4909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+27
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace strict array index assertions with log level grouping - Assert on log content rather than micro-ordering during error conditions - Maintains test coverage while improving reliability for CI - Fixes intermittent failures in advancedUses.test.ts (~40% failure rate) Closes #4907
svozza
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR improves the resilience of Logger e2e tests by replacing strict array index assertions with log level grouping, fixing intermittent test failures in
advancedUses.test.ts.Issue number: closes #4907
The Logger e2e tests were failing intermittently (~40% failure rate) due to inconsistent log ordering when uncaught errors occur. The tests expected logs in a specific sequence, but the uncaught error handler could flush logs in different order, causing assertions to fail on array indices.
Solution
Benefits
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.