improv(commons): expand type utils functions#2189
Merged
Conversation
2 tasks
2 tasks
2 tasks
am29d
suggested changes
Mar 11, 2024
Contributor
am29d
left a comment
There was a problem hiding this comment.
Nice packaged PR, just a minor question on the NaN edge case.
Co-authored-by: Alexander Schueren <sha@amazon.com>
am29d
previously approved these changes
Mar 11, 2024
am29d
previously approved these changes
Mar 11, 2024
Contributor
Author
|
Had to resolve some merge conflicts since both this & #2190 were touching the same section of the It's now ready for approve & merge. Thanks a lot for the review on both! |
|
am29d
approved these changes
Mar 12, 2024
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description of your changes
This PR adds a series of helper functions to the commons utility to get the type of a value at runtime and perform strict equality.
The helper functions existing before this PR are used across many of the Powertools utilities while the ones added in the PR are mainly for the upcoming JMESPath utility. Overtime we can adopt some of the newer ones wherever necessary on the existing codebase.
Related issues, RFCs
Issue number: #2191
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.