fix(logger): reverting logger child modification#4363
Merged
sthulb merged 1 commit intoaws-powertools:developfrom May 17, 2024
leandrodamascena:revert/logger-child
Merged
fix(logger): reverting logger child modification#4363sthulb merged 1 commit intoaws-powertools:developfrom leandrodamascena:revert/logger-child
sthulb merged 1 commit intoaws-powertools:developfrom
leandrodamascena:revert/logger-child
Conversation
|
sthulb
approved these changes
May 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4363 +/- ##
===========================================
- Coverage 96.38% 96.32% -0.06%
===========================================
Files 214 218 +4
Lines 10030 10440 +410
Branches 1846 1930 +84
===========================================
+ Hits 9667 10056 +389
- Misses 259 270 +11
- Partials 104 114 +10 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue number: #4362
Summary
Changes
The PR https://github.com/aws-powertools/powertools-lambda-python/pull/4295/files potentially introduced a breaking change when customer is using many
Loggerinstances with the same service name. This bug occurs locally or running in the Lambda environment.Example:
validate_log.py
validate_log1.py
output
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.