Add --build-graph option#1411
Merged
miparnisari merged 3 commits intoaws-cloudformation:masterfrom Apr 3, 2020
Merged
Conversation
PatMyron
approved these changes
Mar 10, 2020
Contributor
PatMyron
left a comment
There was a problem hiding this comment.
Not a big deal, but still creates an empty .dot file if those dependencies are missing 🤷♂️
This is awesome though!
Contributor
Author
Ah good catch... it's because of networkx/networkx#3865. Will change the code to protect against this. |
added 2 commits
March 29, 2020 17:36
This was referenced Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1391
Description of changes:
Add support for
cfn-lint -t mytemplate.json -g. Ifpydotorpygraphvizare installed, it will output the graph in the same directory as the template linted:mytemplate.json.dot, and then run the linter. If neither of those modules are found, it will print an error but the linting will continue.TO DO:
self._get_argument_value('build_graph', False, False)is correctmytemplate.json.dotlooks ugly -> i'm marking this as done but i'm open to ideasBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.