fix: Gates rolling hash of all supported hash algorithms to TLS1.2#5803
Merged
maddeleine merged 3 commits intoaws:mainfrom Mar 25, 2026
Merged
fix: Gates rolling hash of all supported hash algorithms to TLS1.2#5803maddeleine merged 3 commits intoaws:mainfrom
maddeleine merged 3 commits intoaws:mainfrom
Conversation
jmayclin
approved these changes
Mar 25, 2026
CarolYeh910
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Reducing the number of rolling hash algorithms in TLS1.3 mutual auth.
Why
This many hashes is costing us performance unnecessarily. See related issue for deeper explanation.
How
Gates the rolling hash of all supported hash algs to tls12 client auth case.
Callouts
Testing
Existing mTLS benchmark:
handshake-mTLS/s2n-tls time: [1.2180 ms 1.2202 ms 1.2227 ms]
change: [−0.7820% +0.1216% +1.0380%] (p = 0.81 > 0.05)
No change in performance detected.
With this change:
handshake-mTLS/s2n-tls time: [1.1726 ms 1.1750 ms 1.1780 ms]
change: [−4.8882% −4.0401% −3.1176%] (p = 0.00 < 0.05)
Performance has improved.
On my laptop this improves Mtls TLS13 handshake performance by ~4%.
Related
resolves #5802
release summary: Mtls TLS13 handshakes are ~4% faster
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.