fix(aws-lc): Update test for https://github.com/aws/aws-lc/pull/3101#5788
Merged
CarolYeh910 merged 1 commit intoaws:mainfrom Mar 20, 2026
Merged
fix(aws-lc): Update test for https://github.com/aws/aws-lc/pull/3101#5788CarolYeh910 merged 1 commit intoaws:mainfrom
CarolYeh910 merged 1 commit intoaws:mainfrom
Conversation
nebeid
reviewed
Mar 19, 2026
nebeid
approved these changes
Mar 19, 2026
|
aws/aws-lc#3101 was merged. |
CarolYeh910
approved these changes
Mar 20, 2026
jouho
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix s2n-tls tests to account for AWS-LC API change in aws/aws-lc#3101
Why
So s2n-tls tests keep working.
How
Handle the case where overwriting a valid ec_key with an invalid_key fails, leaving the existing valid key intact, resulting in a successful EC Key Exchange.
Callouts
None
Testing
Locally checked out aws/aws-lc#3101 and ran s2n-tls unit tests against it.
Related
aws/aws-lc#3101
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.