Merged
Conversation
CarolYeh910
approved these changes
Mar 3, 2026
maddeleine
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make
s2n_connection_get_alertidempotent and thread-safe.Why
s2n_connection_get_alertcurrently consumes the alert which is ... odd behavior.It is also not safe to call concurrently, because it mutates the stuffer.
How
We shallow copy the stuffer, so that the write/read cursor increments are local to the function.
Callouts
Technically a behavior change, but I consider this low risk because the scenario where someone is relying on the non-idempotency of this behavior seems unlikely.
Testing
Added a unit test.
Related
#5756
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.